Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staff_graded-xblock | Replace pkg_resources to importlib_resources | Drop support for python 3.8 #278

Merged
merged 4 commits into from
Jan 17, 2025

Conversation

ttqureshi
Copy link
Contributor

@ttqureshi ttqureshi commented Nov 12, 2024

- Add support for python 3.12
- run make upgrade
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, one question about the output in the requirements file. Looks like maybe it's just an out of date version of pip that needs to be updated: jazzband/pip-tools#204

requirements/ci.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirements should be built with the oldest version of python we want to support. I went ahead and just pushed that change.

@feanil feanil merged commit d1f15fb into openedx:master Jan 17, 2025
6 checks passed
@ttqureshi ttqureshi deleted the ttqureshi/depr_pkg_resources branch January 20, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Python 3.8 & Add Support for Python 3.12 Move on from deprecated pkg_resources api
3 participants